fix(invoice): extend instance TTL after state changes - #695
Conversation
|
@abrcrmb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Needs changes Indentation and conditional control flow are broken in set_pool_contract and set_agent_registry_contract due to misplaced closing braces around Self::extend_instance_ttl(&env).
Reviewed commit: |
![mergekeeper[bot]](https://avatars.githubusercontent.com/u/173216192?s=60&v=4){kind=small}
There was a problem hiding this comment.
Needs changes
Indentation and conditional control flow are broken in set_pool_contract and set_agent_registry_contract due to misplaced closing braces around Self::extend_instance_ttl(&env).
contracts/invoice/src/lib.rs:165: Self::extend_instance_ttl(&env) is placed inside the else block with incorrect indentation and changes the control flow unexpectedly.contracts/invoice/src/lib.rs:237: Self::extend_instance_ttl(&env) is placed inside the else block with incorrect indentation and changes the control flow unexpectedly.
Reviewed commit: 42e7506a1521ab5caf6e2dcb60c3f34e688ae57e.
1 participant
This PR fixes issue #559 by ensuring that
set_pool_contract,set_agent_registry_contract,set_escrow_contract,add_supported_asset, andremove_supported_assetcallSelf::extend_instance_ttl(&env)after writing to instance storage, keeping them consistent with other mutators.Closes #559